[Webkit-unassigned] [Bug 33418] [Qt] Custom select popups.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33418





--- Comment #12 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-09 09:08:52 PST ---
(In reply to comment #11)
> Attachment 46208 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKit/qt/QGVLauncher/main.cpp:35:  Found other header before WebCore config.h.
> Should be: config.h, primary header, blank line, and then alphabetically
> sorted.  [build/include_order] [4]

These errors in QGVLauncher can be ignored

> WebKit/qt/Api/qwebpopup.cpp:21:  Found header this file implements before
> WebCore config.h. Should be: config.h, primary header, blank line, and then
> alphabetically sorted.  [build/include_order] [4]

Pls fix

> WebKit/qt/QGVLauncher/custompopup.cpp:21:  Found header this file implements
> before WebCore config.h. Should be: config.h, primary header, blank line, and
> then alphabetically sorted.  [build/include_order] [4]

Ignore

> WebKit/qt/QGVLauncher/custompopup.cpp:127:  One line control clauses should not
> use braces.  [whitespace/braces] [4]

Please fix

> WebKit/qt/Api/qwebpopup.h:27:  Alphabetical sorting problem. 
> [build/include_order] [4]

fix

> WebKit/qt/Api/qwebpage.cpp:1753:  qt_qwebpage_setPopupFactory is incorrectly
> named. Don't use underscores in your identifier names.  [readability/naming]
> [4]

Ignore as we use this for private Qt API

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.