[Webkit-unassigned] [Bug 33418] [Qt] Custom select popups.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33418





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-09 08:17:11 PST ---
+void QWebPage::setPopupFactory(QWebPopupFactory* factory)
+{
+    d->chromeClient->m_popupFactory = factory;
+}
+
+void qt_qwebpage_setPopupFactory(QWebPage* page, QWebPopupFactory* factory)
+{
+    page->setPopupFactory(factory);
+}

If  you wanted to add this as  private API for now, this is not correct. the 
QWebPage::setPopupFactory() cannot exist.

why not 

void qt_qwebpage_setPopupFactory(QWebPage* page, QWebPopupFactory* factory)
{
    d->chromeClient->m_popupFactory = factory;
}
??

Also the chromeClient->m_popupFactory is not acceptable. Please add a setter
instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.