[Webkit-unassigned] [Bug 33418] [Qt] Custom select popups.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33418





--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-09 07:48:02 PST ---
Attachment 46206 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/qt/QGVLauncher/main.cpp:35:  Found other header before WebCore config.h.
Should be: config.h, primary header, blank line, and then alphabetically
sorted.  [build/include_order] [4]
WebKit/qt/Api/qwebpopup.cpp:21:  Found header this file implements before
WebCore config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKit/qt/QGVLauncher/custompopup.cpp:21:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKit/qt/QGVLauncher/custompopup.cpp:115:  One line control clauses should not
use braces.  [whitespace/braces] [4]
WebKit/qt/Api/qwebpopup.h:25:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/Api/qwebpopup.h:26:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/Api/qwebpopup.h:28:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKit/qt/Api/qwebpopup.h:33:  Code inside a namespace should not be indented. 
[whitespace/indent] [4]
WebKit/qt/Api/qwebpage.cpp:1753:  qt_qwebpage_setPopupFactory is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
Total errors found: 9

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.