[Webkit-unassigned] [Bug 30004] [GStreamer] Should handle BUFFERING messages

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30004





--- Comment #10 from Philippe Normand <pnormand at igalia.com>  2010-01-09 05:31:54 PST ---
(In reply to comment #8)
> Why is there the 200ms timeout when receiving a buffering message instead of
> using a idle callback or a timeout of 0? Also async. bus signals/watches are
> always going through the main thread, no need to do a timeout just for GTK
> threading requirements.
> 

If I set the timeout to 0 the source is immediately removed because the stop
value of the buffering range is -1.

> When the duration changes after a buffering query, shouldn't you call
> durationChanged() to signal the change?
> 

yes :)

> Apart from that it looks good (except some code style issues), but I don't know
> the media player API and if all this is the desired behaviour :)
> 

Well the style-bot didn't complain ;) But what is in your mind?

> Oh and one small thing... the queueing/buffering is done by playbin2, not
> decodebin2 as the comment says ;)

Oops right, I confused with uridecodebin in fact. The queue2 behavior is set
there, as far as I could see in the code, right?

(In reply to comment #9)
> ...and buffering also happens when no temp file name exists, for example when
> playing a random HTTP stream without a temporary file. In those cases you want
> to show the buffering state too I think.

Hm yes, so I guess I can rely on m_startedBuffering instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.