[Webkit-unassigned] [Bug 33405] [OpenVG] Implement a basic GraphicsContext on top of a new PainterOpenVG class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33405





--- Comment #4 from Dirk Schulze <krit at webkit.org>  2010-01-09 01:54:34 PST ---
(From update of attachment 46166)
> +++ b/WebCore/platform/graphics/openvg/GraphicsContextOpenVG.cpp

> +void GraphicsContext::fillRect(const FloatRect& rect, const Color& color, ColorSpace colorSpace)
> +{
> +    if (paintingDisabled())
> +        return;
> +
> +    PainterOpenVG* painter = m_data->painter();
> +    Color oldColor = painter->fillColor();
> +    painter->setFillColor(color);
> +    painter->drawRect(rect, VG_FILL_PATH);
> +    painter->setFillColor(oldColor);
> +}

Is it realy neccessary to store the current fill color of the painter and reset
is after the painting of the rect? The Cairo port also overwrites the current
color, but we do not reset it after the drawing. But maybe it's a bug there. Do
you have an example, where this is needed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.