[Webkit-unassigned] [Bug 33390] New: bindings/v8/DOMData is missing a virtual destructor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33390

           Summary: bindings/v8/DOMData is missing a virtual destructor
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Android
        OS/Version: Android
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: andreip at google.com
                CC: android-webkit-unforking at google.com


DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes
but it does not have a virtual destructor. While this isn't currently causing
any leaks, since there are no instances of ChildThreadDOMData or
MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC
compiler generates the following compilation error:

"/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual
functions and accessible non-virtual destructor"

We therefore need to add a virtual destructor to DOMData.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.