[Webkit-unassigned] [Bug 33353] [GTK] loading test should use SoupServer instead of actual sites

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 8 03:49:41 PST 2010


--- Comment #4 from Gustavo Noronha (kov) <gns at gnome.org>  2010-01-08 03:49:41 PST ---
(In reply to comment #3)
> (From update of attachment 46097 [details])
> >+/* For real request testing */
> >+static void
> >+server_callback(SoupServer *server, SoupMessage *msg,
> >+                const char *path, GHashTable *query,
> >+                SoupClientContext *context, gpointer data)
> This style issue you should fix at least.
> BTW, I'm not sure I see any valid reason to not use the WebKit style in our
> tests too. Not in this patch, but we should do it afterwards.
> Everything else looks good to me, thanks for working on this.

True. I guess it just started like this. I can move them to webkit style.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list