[Webkit-unassigned] [Bug 33353] [GTK] loading test should use SoupServer instead of actual sites

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33353


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-07 16:42:30 PST ---
Attachment 46097 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/tests/testloading.c:32:  Declaration has space between * and
variable name in SoupURI* base_uri  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:32:  base_uri is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:91:  get_uri_for_path is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:93:  Declaration has space between * and
variable name in SoupURI* uri  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:94:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:94:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:98:  Extra space before ( in function call 
[whitespace/parens] [4]
WebKit/gtk/tests/testloading.c:148:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:148:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:208:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:208:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:271:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:271:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:315:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:315:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:316:  Declaration has space between * and
variable name in char* uri_string2  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:316:  uri_string2 is incorrectly named. Don't
use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:343:  load_error_test is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:350:  Declaration has space between * and
variable name in char* uri_string  [whitespace/declaration] [3]
WebKit/gtk/tests/testloading.c:350:  uri_string is incorrectly named. Don't use
underscores in your identifier names.  [readability/naming] [4]
WebKit/gtk/tests/testloading.c:394:  Declaration has space between * and
variable name in SoupServer* server  [whitespace/declaration] [3]
Total errors found: 21

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.