[Webkit-unassigned] [Bug 33065] [chromium] Linux: add support for per-strike font render preferences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33065


Adam Langley <agl at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45949|0                           |1
        is obsolete|                            |
  Attachment #46091|                            |review?, commit-queue-
               Flag|                            |




--- Comment #18 from Adam Langley <agl at chromium.org>  2010-01-07 15:22:38 PST ---
Created an attachment (id=46091)
 --> (https://bugs.webkit.org/attachment.cgi?id=46091)
Addressing fishd's comments

> nit: indent by 4 spaces.
> kNoPreference should be NoPreference without the "k" prefix.

Done

> ^^^ nit: please insert a new line after familyForChars.

Done

> nit: isn't it better style to list out parameters last?  or perhaps this should
> just be a return value?

I've moved the outarg to the end, although generally I disagree. Destinations
usually come first: memcpy, strcpy, '=' etc

> are there no constants that can be used in place of these magic numbers?

There's a great big comment in the .h file so I'm not too worried.

> nit: no need for the WebCore:: prefix above.

Done


Cheers

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.