[Webkit-unassigned] [Bug 33344] New: remove plugins/get-url-that-the-resource-load-delegate-will-disallow.html ?
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 7 13:46:25 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33344
Summary: remove
plugins/get-url-that-the-resource-load-delegate-will-d
isallow.html ?
Product: WebKit
Version: 528+ (Nightly build)
Platform: Other
OS/Version: Mac OS X 10.5
Status: UNCONFIRMED
Severity: Normal
Priority: P2
Component: Tools / Tests
AssignedTo: webkit-unassigned at lists.webkit.org
ReportedBy: robert at roberthogan.net
The code that this test relates to is gone. It was added by
http://trac.webkit.org/changeset/20694, which fixed a crash in
WebKit/Plugins/WebNetscapePluginStream.mm. The crash was caused by the lines
removed below:
loader->documentLoader()->addPlugInStreamLoader(_loader);
- if (!_loader->load(request))
- _loader->documentLoader()->removePlugInStreamLoader(_loader);
+ _loader->load(request);
The implementation is now shared, or at least WebBaseNetscapePluginStream.mm
maintains a copy of PluginStream.cpp which has always had:
void PluginStream::start()
{
ASSERT(!m_loadManually);
m_loader = NetscapePlugInStreamLoader::create(m_frame, this);
m_loader->setShouldBufferData(false);
m_loader->documentLoader()->addPlugInStreamLoader(m_loader.get());
m_loader->load(m_resourceRequest);
}
Also, the crash situation doesn't arise for ports that do not implement a
ResourceLoadDelegate. So should such ports implement the layoutTestController
method the test requires and some drt specific code into the frameloaders to
pass this test or should it be removed/moved to platform-specific tests?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list