[Webkit-unassigned] [Bug 33268] make JPEG image dcoder read segmented SharedBuffer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33268





--- Comment #17 from Peter Kasting <pkasting at google.com>  2010-01-07 11:19:39 PST ---
(In reply to comment #15)
> > should I fix all existing style issues in the file?
> 
> I'm not sure about this file in specific, but the GIF image decoder, for
> example, is not in WebKit style on purpose.

Well, the GIF image "reader" (I'm using the names the files give themselves) is
not, because the whole file was copied.  The "decoder" portion is.

In the JPEG/PNG cases, the decoders should in theory be in webkit style, except
that in some cases we use names that match the libjpeg/libpng interfaces for
clarity, even though it violates WK style.

If there are more style problems than those, it'd be nice to fix them, although
if it's very many, I'm not sure it's fair to Yong to mandate fixing the whole
file when it's touched.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.