[Webkit-unassigned] [Bug 33089] Implement alphabetic CSS3 list-style-types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 7 11:02:23 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33089





--- Comment #12 from Darin Adler <darin at apple.com>  2010-01-07 11:02:22 PST ---
(In reply to comment #11)
> Maybe we should remove this comment? or better yet, either refer to section
> CSS_PROP_LIST_STYLE_TYPE in file CSSValueKeywords.in or to the enum
> EListStyleType in RenderStyleConstants.h.

Yes, we should do something like that.

> For your reference, they are ordered according to how they appear in the spec.

Eventually I figured that out.

> > In most cases, we use names for characters rather than just putting the number
> > in. That's typically done by adding named constants to CharacterNames.h that
> > exactly match the names from the Unicode specification. The exception would be
> > in a table where there are so many characters it is not helpful. This seems
> > like a case where the name would be better.

You didn't do the "Will change" on this one. I hope you decide to do it.

> For your reference, the tables for hiragana-iroha, hiragana, katakana-iroha,
> katakana are currently in in the tree.

And they are probably wrong? That is worth fixing, although naturally not in
this patch.

> From my understanding, we can't use "//"-style comments in CSS as per section
> 4.1.9 of the CSS 2.1 spec. <http://www.w3.org/TR/CSS2/syndata.html#comments>.
> So, we have to use C-style comments (i.e. /* ... */).

I see.

> I included a render-tree dump, which includes the text for the list marker
> character. So, this can be tested using DRT.

Yes, understood.

> Ideally, we should add a dumpListMarkersAsText() command to DRT so that we can
> just use dumpAsText. This is best addressed in a separate bug.

Or we could make dumping the list markers the default, and update existing test
results. Most tests won't have any list markers. I think either of these is
well worth doing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list