[Webkit-unassigned] [Bug 33150] Do not render the full frame when there is some elements with fixed positioning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33150


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #15 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-01-07 04:20:19 PST ---

> > I dislike the method name. Shouldn't it always be fast? 
> 
> No, there are some cases when you cannot avoid the slow path. For example, if
> the view is not opaque, you need full repaint.

scrollContentsFastPath :-) ?


> This would not be correct. You can have updateInvalidSubRect == true and
> objectsFixedInViewport.isEmpty() in the case where all fixed object are under a
> transformed layer in the hierarchy.

OK. maybe invalidated is better than invalid. Maybe add a comment as the above
as well?

> > Wrong indentation
> 
> Is it? The coding convention says 4 spaces, not 3.

Yes your change is right. I just noticed that you changed the indentation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.