[Webkit-unassigned] [Bug 33287] New: PNGEncoder.cpp lacks support for libpng 1.4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 19:52:19 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33287

           Summary: PNGEncoder.cpp lacks support for libpng 1.4
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Trivial
          Priority: P5
         Component: Platform
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: jbowler at acm.org


Certain NULL macros were removed from png.h between 1.2 and 1.4, this patch
fixes it (you probably want to use your favourite NULL definition, not 0).

---
chromium-4.0.251.0/third_party/WebKit/WebCore/platform/image-encoders/skia/orig/PNGImageEncoder.cpp
   2009-11-19 13:39:07.000000000 -0800
+++
chromium-4.0.251.0/third_party/WebKit/WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp
   2009-11-19 13:39:25.000000000 -0800
@@ -130,9 +130,9 @@
     }

     png_struct* pngPtr = png_create_write_struct(PNG_LIBPNG_VER_STRING,
-                                                 png_voidp_NULL,
-                                                 png_error_ptr_NULL,
-                                                 png_error_ptr_NULL);
+                                                 0,
+                                                 0,
+                                                 0);
     if (!pngPtr)
         return false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list