[Webkit-unassigned] [Bug 33269] Improve HTMLElement::tagPriority()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33269





--- Comment #9 from TAMURA, Kent <tkent at chromium.org>  2010-01-06 18:35:14 PST ---
(In reply to comment #7)
> (From update of attachment 45999 [details])
> > +// TagPriorityMap returns 1 for unregistered tags. It's same as <span>.
> > +// This way custom tag name elements will behave like inline spans.
> 
> I think this comment should be at the bottom of initializeTagPriorityMap.

Moved it.

> 
> > +static const TagPriorityMap* initializeTagPriorityMap()
> 
> Given that this actually creates the map too, I suggest naming it
> createTagPriorityMap.

Renamed it.

> r=me assuming that localName().impl() is *not* ever 0
> 
> If it can be zero, then this patch is not OK.

I read the HTMLParser, HTMLTokenizer, HTMLDocument, Document classes carefully
and confirmed localName() never be null.  I also confirmed all LayoutTests
passed with ASSERT(localName().impl()).
I'll add this assertion and will commit it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.