[Webkit-unassigned] [Bug 33150] Do not render the full frame when there is some elements with fixed positioning

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33150





--- Comment #8 from Benjamin Poulain <benjamin.poulain at nokia.com>  2010-01-06 14:30:53 PST ---
Thanks for the reviews.

(In reply to comment #5)
> (From update of attachment 45892 [details])
> (1) ScrollView is not designed to know anything about the render tree or
> RenderObjects directly.  I'd move the HashSet to FrameView and then make a
> virtual method that is called in ScrollView.

I have moved the logic to a function called ScrollView::fastScrollContents()
that is reimplemented in FrameView.

> (2) Please make a constant for the cutoff number in the code.  Don't just use 5
> inline like that.

Done :)

> (3) You should disregard fixed positioned objects inside transforms, as they
> aren't actually fixed to the ScrollView.  You can verify this by checking if
> the containingBlock is actually the RenderView for each RenderObject before
> allowing it to be registered.

You are right.

I have updated the patch to take transformations to register only
non-transformed objects.

About verifying if the containingBlock is the RenderView, I now do that in the
scrolling code. I don't think I can do that at the time of registering the
object because its parent might get a transformation later.

> (4) Why not make fixed background images work too?  They are just as common (if
> not moreso) than fixed positioning.

I try to keep the patches small and I have another idea for fixed elements. I
can fix background images later.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.