[Webkit-unassigned] [Bug 20736] [GTK] GtkWebKit incompatible with rgba colormaps

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=20736


Benjamin Otte <otte at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |otte at gnome.org




--- Comment #17 from Benjamin Otte <otte at gnome.org>  2010-01-06 10:35:44 PST ---
2 things from looking at the patch:
1) GtkThemeParts are allocated with g_slice_new0() but cleared with g_free()
(in the hashtable).
2) I don't like using the hash table. Couldn't we have an API like:
/* call once per page and store in RenderThemeGtk */
GtkThemeParts *gtk_theme_parts_new (GdkDrawable *);
/* call instead of moz_gtk_use_parts_for_drawable */
void gtk_theme_parts_use (GtkThemeParts *);
/* obvious */
gtk_theme_parts_free (GtkThemeParts *);
That gets rid of stupid globals.
It does create new widgets for every RenderTheme. I don't think it matters
though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.