[Webkit-unassigned] [Bug 33252] Allow custom memory allocation control for IconDatabaseClient class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 6 09:38:23 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=33252





--- Comment #4 from Darin Adler <darin at apple.com>  2010-01-06 09:38:22 PST ---
(In reply to comment #3)
> This is an Abstract Base Class.

It's not. It has no pure virtual functions and is instantiated, as the patch
says, on line 89 of IconDatabase.cpp.

However, I think it would make more sense if it was an abstract base class. The
version that does nothing could be derived from it.

I think there's no harm in making the change from this patch, but it's not
great to have this client different from other clients.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list