[Webkit-unassigned] [Bug 33159] Make JSObject::getPropertyNames() non-virtual

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33159





--- Comment #7 from Kent Hansen <kent.hansen at nokia.com>  2010-01-06 01:17:25 PST ---
(In reply to comment #6)
> > JSDOMWindow: There will no longer be an "early cut-off" when getPropertyNames()
> > is called on a JSDOMWindow that's not accessible from the current context;
[snip]
> These issues seem to be deal-breakers for making getPropertyNames nonvirtual.
> 
> You could add a separate checkAccess-style virtual function, but then you've
> just traded one virtual function for another. What's the benefit?

Yep. I was far into the patch when realizing this issue. I took another look at
the patch that introduced getOwnPropertyNames(), and indeed, the reason it kept
getPropertyNames() virtual was to keep the security behavior intact. So I'd say
it's not justified to change this as it stands, since introducing the virtual
access-check would require refactoring elsewhere and potentially slow things
down.

Oh well, at least I found some other bugs & interesting things in the process;
thanks for verifying those!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.