[Webkit-unassigned] [Bug 33246] New: bugzilla-tool land-diff should warn when changelog doesn't match committer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33246

           Summary: bugzilla-tool land-diff should warn when changelog
                    doesn't match committer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ojan at chromium.org
                CC: eric at webkit.org, abarth at webkit.org


I just had the following happen:
1. git svn rebase successfully merged my ChangeLog file, but didn't put my
entry at the top
2. bugzilla-tool land-diff committed my change with the wrong commit message

See http://trac.webkit.org/changeset/52844

Technically, I should have noticed in the diff that the ChangeLog entry wasn't
at the top, but it would be nice to be a bit more idiot-proof. Can land-diff
confirm that you want to commit if the email address doesn't match git's
configured email address? Obviously, this would always be true on the commit
bot, but for human beings committing, I think this is by far the common case
(i.e. that they're committing their own patches).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.