[Webkit-unassigned] [Bug 33004] NetworkStateNotifierWin.cpp doesn't work always

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33004


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45584|review?                     |review-
               Flag|                            |




--- Comment #6 from Adam Roben (aroben) <aroben at apple.com>  2010-01-05 14:47:13 PST ---
(From update of attachment 45584)
> +NetworkStateNotifier::~NetworkStateNotifier()
> +{
> +    m_closeAddrChangeWaitThread = true;
> +    ::CloseHandle(m_overlapped.hEvent);
> +    ::WaitForSingleObject(m_waitHandle, INFINITE);
> +    ::CloseHandle(m_waitHandle);
>  }

NetworkStateNotifier is a singleton that is never destroyed. This code will
never be called.

It seems like the real fix here is to call NotifyAddrChange again after we
receive a notification. Why can't we just add another call to
NotifyAddrChange/RegisterWaitForSingleObject inside addressChanged()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.