[Webkit-unassigned] [Bug 33219] New: Add assertions to catch double-destruction of WebViews earlier

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33219

           Summary: Add assertions to catch double-destruction of WebViews
                    earlier
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: aroben at apple.com
                CC: sam at webkit.org



Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45909|                            |review?
               Flag|                            |


Created an attachment (id=45909)
 --> (https://bugs.webkit.org/attachment.cgi?id=45909)
Patch

I basically copied the m_deletionHasBegun logic from WTF::RefCounted.

Need a short description and bug URL (OOPS!)

Reviewed by NOBODY (OOPS!).

* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.

* WebView.h: Added m_deletionHasBegun.
---
 3 files changed, 32 insertions(+), 1 deletions(-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.