[Webkit-unassigned] [Bug 33153] Running multiple instances of run-webkit-tests is not possible on the same machine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33153


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45893|review?                     |review+
               Flag|                            |




--- Comment #21 from Darin Adler <darin at apple.com>  2010-01-05 10:41:47 PST ---
(From update of attachment 45893)
> +        my $oldPid = `cat "$httpdPidFile"`;

Just for the record, this works for spaces and single quotes and other
metacharacters, but not for dollar signs or double quote marks. It's easy to
read a number out of a file without using backticks or invoking the shell; that
would be more robust. Not important for this patch.

> +    while ((0 != kill 0, $httpdPid) && $retryCount) {

I find this while expression really confusing. Especially the ", $httpPid" part
of it. And I also can't tell what value the "0 !=" adds in the expression "0 !=
kill 0".

The code will now return, leaving $isHttpdOpen set to 1, if the pid file
doesn't exist. I'm not sure that's a good change in behavior.

r=me as is, but you could consider my comments above too even though I don't
think any are showstoppers

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.