[Webkit-unassigned] [Bug 33153] Running multiple instances of run-webkit-tests is not possible on the same machine

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33153





--- Comment #17 from Andras Becsi <abecsi at inf.u-szeged.hu>  2010-01-05 07:58:56 PST ---
(In reply to comment #16)
> (From update of attachment 45883 [details])
> > +        my $oldPid = `cat $httpdPidFile`;
> 
> Doing it this way assumes there are no spaces in tmpdir. I'm not sure that will
> always be true. To make this work in all cases quoting since you are passing
> this path to the shell.
Right, the quotes would make it more robust. I'll fix that.
> 
> > +    die "Timed out waiting for httpd to terminate" unless $retryCount;
> 
> Why is this a good idea?
> 
> > +    rmdir $httpdPidDir;
> 
> How can this rmdir work on a non-empty directory? What deletes the file?
If httpd terminates it deletes the httpd.pid and httpd.scoreboard files form
$httpdPidDir, that is why we need a while loop after sending kill 15 to the
process. After successfull termination the directory is empty. I've put the die
there to indicate that someting went wrong, because after sending kill 15 and
sleeping 20 secs the process still didn't terminate.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.