[Webkit-unassigned] [Bug 33198] Reorganize, document and rename OS() platform macros.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33198


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-05 00:14:12 PST ---
Attachment 45868 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/GraphicsContext3D.cpp:355:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/platform/graphics/SimpleFontData.h:143:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/platform/graphics/SimpleFontData.h:230:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/plugins/PluginPackage.cpp:129:  Should have a space between // and
comment  [whitespace/comments] [4]
JavaScriptCore/runtime/DatePrototype.cpp:200:  Extra space before ( in function
call  [whitespace/parens] [4]
JavaScriptCore/wtf/Platform.h:320:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:321:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:382:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:383:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:384:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:385:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:386:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:387:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:388:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:389:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:390:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:391:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:394:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:909:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:910:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/Platform.h:911:  Weird number of spaces at line-start.  Are
you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 21

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.