[Webkit-unassigned] [Bug 33197] New: bugzilla-tool submit-patch mistakenly picks up bug URLs in non-ChangeLog files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33197

           Summary: bugzilla-tool submit-patch mistakenly picks up bug
                    URLs in non-ChangeLog files
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mjs at apple.com


I tried to make a new bug and upload a patch with bugzilla-tool submit patch,
containing the hunk below. Instead of creating a new bug, bugzilla-tool assumed
this was a patch for 29268. There are two problems with this:

1) The bug URL was not in a ChangeLog.
2) The line containing the bug URL was not even added in the patch, it was just
context.

I think bugzilla-tool should only look for bug URLs in ChangeLogs, and only in
+ lines.


Index: JavaScriptCore/wtf/Platform.h
===================================================================
--- JavaScriptCore/wtf/Platform.h       (revision 52782)
+++ JavaScriptCore/wtf/Platform.h       (working copy)
@@ -790,11 +804,11 @@
 #endif

 #if !defined(WTF_USE_JSVALUE64) && !defined(WTF_USE_JSVALUE32) &&
!defined(WTF_USE_JSVALUE32_64)
-#if (CPU(X86_64) && (PLATFORM(UNIX) || PLATFORM(WIN_OS))) || CPU(IA64) ||
CPU(ALPHA)
+#if (CPU(X86_64) && (OS(UNIX) || OS(WINDOWS))) || CPU(IA64) || CPU(ALPHA)
 #define WTF_USE_JSVALUE64 1
 #elif CPU(ARM) || CPU(PPC64)
 #define WTF_USE_JSVALUE32 1
-#elif PLATFORM(WIN_OS) && COMPILER(MINGW)
+#elif OS(WINDOWS) && COMPILER(MINGW)
 /* Using JSVALUE32_64 causes padding/alignement issues for JITStubArg
 on MinGW. See https://bugs.webkit.org/show_bug.cgi?id=29268 */
 #define WTF_USE_JSVALUE32 1

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.