[Webkit-unassigned] [Bug 33188] ER: Need a way to know when FrameLoader is loading a URL based on user action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33188





--- Comment #7 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-01-04 23:02:58 PST ---
(In reply to comment #6)
> (From update of attachment 45848 [details])
> We aren't accepting FrameLoader patches without tests.
> 
> That said, this code is wrong, mostly because all our user gesture code is
> wrong.  Why is frame->script()->processingUserGesture() insufficient?  I think
> the correct fix is to teach that function to return the correct answer.

Currently, the userGesture flag is set only when
ScriptController::executeIfJavaScriptURL() is called, and thus only when a
javascript: URL is clicked.  I need this to work with plain (non-javascript)
links as well, which it doesn't today.

> Basically, the right way to do this is when an event enters WebKit (or maybe
> WebCore), we know whether it's a real user input event or a fake event.  At
> that time, we should create a scoped object that stores the user gesture state
> in a static.  script()->processingUserGesture should then read the static.  The
> current approach of trying to recover the information from Event is wrong and
> doesn't work in edge cases.

At what scope should this object exist?  Inside the ScriptController?  I'm not
sure what you mean exactly by a "scoped object".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.