[Webkit-unassigned] [Bug 32571] Support the aria-checked attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32571


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45846|review?                     |review+
               Flag|                            |




--- Comment #22 from Darin Adler <darin at apple.com>  2010-01-04 17:24:39 PST ---
(From update of attachment 45846)
> +        if (equalIgnoringCase(getAttribute(aria_checkedAttr).string(), "true"))

You should omit the .string() here.

>      bool isRequired() const;
>      bool isSelected() const;
>      bool isExpanded() const;
> +    bool isChecked();

Why not const?

>      int hierarchicalLevel() const;
>      double clickPointX();
>      double clickPointY();

> +bool AccessibilityUIElement::isChecked()
> +{
> +    return static_cast<bool>(intValue());
> +}

Normally an int to bool conversion would not require an explicit cast.

> +    return (intValue() == 1);

No need for the parentheses here.

> +    return (vState.lVal & STATE_SYSTEM_CHECKED);

Or here.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.