[Webkit-unassigned] [Bug 33188] New: ER: Need a way to know when FrameLoader is loading a URL based on user action

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33188

           Summary: ER: Need a way to know when FrameLoader is loading a
                    URL based on user action
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Page Loading
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: beidson at apple.com, bolsinga at apple.com


Created an attachment (id=45844)
 --> (https://bugs.webkit.org/attachment.cgi?id=45844)
Brain-dead implementation using FrameLoader::isProcessingUserGesture()

* SUMMARY
In order to display the "Download Failed" alert in MobileSafari, we need to
know if a user tapped on a link within an <iframe> or <frame> element versus
the URL being loaded as part of the HTML source or being loaded automatically
using JavaScript (document.write or setting the location in the frame's
document).

This essentially translates to storing the userGesture flag in
FrameLoader::urlSelected() and resetting it elsewhere.  I've attached a patch
that works (on the surface), but it sets m_userNavigation to false twice in
some code paths, and sets it three times (twice to false and once to the value
of 'userGesture') in the code path we're interested in.  It also assumes that
modifying FrameLoader::isProcessingUserGesture() is sufficient to check the
value of m_userNavigation.

Basically, I need to figure out the best place to save and reset
m_userNavigation, and whether it's acceptable to check it in
FrameLoader::isProcessingUserGesture().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.