[Webkit-unassigned] [Bug 30098] commit-queue can wrongly reject patches if the buildbots are behind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30098





--- Comment #17 from Adam Barth <abarth at webkit.org>  2010-01-04 15:13:13 PST ---
> Slightly confused by the second _builders_are_green() check?  (might need a
> comment?)

I added that because you mentioned that build-and-test could take a while.  If
the bots have gone red in the meantime (say on Windows), then we don't want to
land in order to avoid making the tree worse.

> Won't land-attachment check for us?

If that's the case, then why was the code there originally to check the
builders?  I'd be happy to remove it if you think the subprocess should handle
checking the builders.  I'd be more inclined to have to pass --ignore-builders
and have the master process deal with deciding whether its time to run
land-attachment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.