[Webkit-unassigned] [Bug 30098] commit-queue can wrongly reject patches if the buildbots are behind

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30098





--- Comment #14 from Adam Barth <abarth at webkit.org>  2010-01-04 15:02:33 PST ---
> should include the revision number that it tried, and should include the
> results spew, no?

It could, but no one is going to see the message expect maybe you.  The EWS
also as a similar idle message and I've never been interested in why they
didn't build.

> Also, shouldn't it prefix with ERROR: so that it shows up purple?

This doesn't show up purple anywhere because it's not associated with any
patch.  It's just an idle message like "Builders [%s] are red."

I'm tempted to remove the message instead of making it more complicated.

> Probably should have a comment to explain the --no-update here:

Done.

> I'll say r+, but I think this needs modifications to report the status of the
> failed test build better.  That will help us more easily debug flakey tests
> (and will make the dashboard correctly show purple).

Flakey tests will just make the commit-queue wait five minutes before landing a
patch occasionally.  If we get a flaky test 1% of the time, this will add 3
seconds of average latency, which is lost in the noise of the 5 minute polling
frequency.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.