[Webkit-unassigned] [Bug 33065] Chromium Linux: add support for per-strike font render preferences

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 15:02:08 PST 2010


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
                 CC|                            |levin at chromium.org

--- Comment #14 from David Levin <levin at chromium.org>  2010-01-04 15:02:06 PST ---
(In reply to comment #13)
> > WebKit/chromium/src/gtk/WebFontInfo.cpp:143:  Use 0 instead of NULL. 
> Note to reviewers: false positive. This mention of NULL is in a comment.

fwiw, this isn't a false positive as the script specifically checks for NULL in
comments. Several reviewers flag this in reviews. 

For example, https://bugs.webkit.org/show_bug.cgi?id=22700#c22
  "We do not use NULL in code, so using it in comments isn't appropriate
either. I
suggest lower case "null" or 0."

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list