[Webkit-unassigned] [Bug 33167] Add a test harness for the Windows WebKit API, and a few tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33167


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #1 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-01-04 12:06:57 PST ---
Attachment 45814 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/WebKitAPITest/HostWindow.cpp:25:  Found header this file implements
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WebKitAPITest/main.cpp:25:  Found other header before WebCore
config.h. Should be: config.h, primary header, blank line, and then
alphabetically sorted.  [build/include_order] [4]
WebKitTools/WebKitAPITest/Test.h:51:  TEST_CLASS_NAME is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitAPITest/Test.h:53:  TEST_CLASS_NAME is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitAPITest/Test.h:55:  More than one command on the same line 
[whitespace/newline] [4]
WebKitTools/WebKitAPITest/Test.h:57:  One line control clauses should not use
braces.  [whitespace/braces] [4]
WebKitTools/WebKitAPITest/TestsController.cpp:25:  Found header this file
implements before WebCore config.h. Should be: config.h, primary header, blank
line, and then alphabetically sorted.  [build/include_order] [4]
WebKitTools/WebKitAPITest/TestsController.h:30:  Alphabetical sorting problem. 
[build/include_order] [4]
WebKitTools/WebKitAPITest/tests/WebViewDestruction.cpp:25:  Found other header
before WebCore config.h. Should be: config.h, primary header, blank line, and
then alphabetically sorted.  [build/include_order] [4]
Total errors found: 9

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.