[Webkit-unassigned] [Bug 33153] Running multiple instances of run-webkit-tests is not possible on the same machine

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 09:16:33 PST 2010


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
  Attachment #45802|review?                     |review-
               Flag|                            |

--- Comment #4 from Darin Adler <darin at apple.com>  2010-01-04 09:16:31 PST ---
(From update of attachment 45802)
> +my $httpdPidDir = File::Spec->tmpdir()."/WebKit";

We normally put spaces around operators like the "." here.

> -    mkdir "/tmp/WebKit";
> +    mkdir "$httpdPidDir";

It doesn't make sense to keep the quote marks here.

> +    if (-f "$httpdPidFile") {

Or here.

> -    kill 15, `cat /tmp/WebKit/httpd.pid` if -f "/tmp/WebKit/httpd.pid";
> +    kill 15, `cat "$httpdPidFile"` if -f "$httpdPidFile";

Or here on the argument to -f.

> +    rmtree "$httpdPidDir";

Or here.

I am surprised the old code did not remove the pid directory.

I think it would be more elegant to call unlink on the file and then rmdir on
the directory instead of using rmtree here.

I'm going to say review- even though my comments are only minor style things.
It would be nice to make it a little cleaner.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list