[Webkit-unassigned] [Bug 33091] SVGResources don't invalidate if target object changes attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33091


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45760|review?                     |review+
               Flag|                            |




--- Comment #3 from Nikolas Zimmermann <zimmermann at kde.org>  2010-01-03 15:19:13 PST ---
(From update of attachment 45760)
Looks almost fine, please change following before landing:

> +void SVGStyledElement::invalidateResources()
> +{
Retrieve document via DOM, not render tree, and early exit when parsing:
Document* document = this->document();
if (!document->parsing())
    return;

You could also use "doc", and save the "this->", but I think it's a stylerule
to not use abbreviations, if possible, so let's enforce it.

r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.