[Webkit-unassigned] [Bug 33069] svg background color on selected text goes wrong when text has gradient stroke.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 2 18:23:01 PST 2010


--- Comment #6 from MORITA Hajime <morrita at gmail.com>  2010-01-02 18:23:00 PST ---
Thank you for quick feedback!

(In reply to comment #5)
> Do they all use gradient fill text?
This change affects SVG text selection rendering
even if it is not with gradient. 

Original code paints background twice; 
Once at fill subphase and another at stroke subphase,
in following order:

1. paintCharacters() for fill
1.1. paint background
1.2. paint glyph for fill
2. paintCharacters() for stroke
2.1. paint background (again)
2.2. paint glyph for stroke.

So 2.1 (background painting on stroke subphase) overwrites
the filled glyphs (with half opacity).
The patch split background painting out to its own subphase,
then filled glyphs are no longer overwritten.
This change requires some test results rebasing.
But it seems reasonable for me.

Slightly OT:
Painting foreground and text decorations may have same issue.
But currently I have no idea to unveil them.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list