[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jan 2 16:12:52 PST 2010
https://bugs.webkit.org/show_bug.cgi?id=33096
--- Comment #5 from Robert Hogan <robert at roberthogan.net> 2010-01-02 16:12:51 PST ---
(In reply to comment #4)
> (From update of attachment 45733 [details])
> How does this interact with the central LayoutTestController code?
> http://trac.webkit.org/browser/trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp#L865
>
> Does Qt not use that code?
>
No, it's completely independent of it. The call stack leading up to a function
in Qt's LayoutTestController is typically:
#0 LayoutTestController::waitForPolicyDelegate (this=0x81a4ef8) at
/home/robert/Development/webkit/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:364
#1 0x0806c20e in LayoutTestController::qt_metacall (this=0x81a4ef8,
_c=QMetaObject::InvokeMetaMethod, _id=53, _a=0xbfffe3ac) at
moc_LayoutTestControllerQt.cpp:239
#2 0x01d24637 in JSC::Bindings::QtRuntimeMetaMethod::call (exec=0xb7aa70f0,
functionObject=0xb7a42dc0, args=...) at
../../../../WebCore/bridge/qt/qt_runtime.cpp:1359
#3 0x0158f2e9 in cti_op_call_NotJSFunction () from
/home/robert/Development/webkit/WebKitBuild/selectedrange/Debug/lib/libQtWebKit.so.4
#4 0x0158b721 in JSC::JITThunks::tryCacheGetByID(JSC::ExecState*,
JSC::CodeBlock*, JSC::ReturnAddressPtr, JSC::JSValue, JSC::Identifier const&,
JSC::PropertySlot const&, JSC::StructureStubInfo*) () from
/home/robert/Development/webkit/WebKitBuild/selectedrange/Debug/lib/libQtWebKit.so.4
#5 0x01548157 in JSC::JITCode::execute (this=0x8205498, registerFile=0x81afddc,
callFrame=0xb7aa7050, globalData=0x81ae208, exception=0x81aecc4) at
../../../../JavaScriptCore/jit/JITCode.h:79
#6 0x0155014c in JSC::Interpreter::execute (this=0x81afdd0,
functionExecutable=0x8205488, callFrame=0x81f1c5c, function=0xb7a42c00,
thisObj=0xb7a40000, args=..., scopeChain=0x81e7098, exception=0x81aecc4) at
../../../../JavaScriptCore/interpreter/Interpreter.cpp:685
#7 0x015e6cb9 in JSC::JSFunction::call (this=0xb7a42c00, exec=0x81f1c5c,
thisValue=..., args=...) at
../../../../JavaScriptCore/runtime/JSFunction.cpp:120
#8 0x015b96a5 in JSC::call (exec=0x81f1c5c, functionObject=...,
callType=JSC::CallTypeJS, callData=..., thisValue=..., args=...) at
../../../../JavaScriptCore/runtime/CallData.cpp:39
#9 0x016ec8a6 in WebCore::JSEventListener::handleEvent (this=0x81b0e30,
scriptExecutionContext=0x81aa190, event=0x81ec3f0) at
../../../../WebCore/bindings/js/JSEventListener.cpp:113
#10 0x0186a1af in WebCore::EventTarget::fireEventListeners (this=0x81a4a48,
event=0x81ec3f0) at ../../../../WebCore/dom/EventTarget.cpp:297
#11 0x01ae7691 in WebCore::DOMWindow::dispatchEvent (this=0x81a4a48,
prpEvent=..., prpTarget=...) at ../../../../WebCore/page/DOMWindow.cpp:1337
> Also, it seems that the x-platform LayoutTestController turns off profiling
> after every test, which it seems you might need to do too. I think this patch
> is wrong, or at least incomplete judging by my quick scan of
> LayoutTestController.cpp. Feel free to re-mark this r? if I'm
> misunderstanding.
The Qt QWebInspector is created at the start of each new test and deleted once
it's finished - it's managed in the DRT's subclass of qwebpage's constructor
and destructor, so I think closewebinspector() is redundant as is
settimelineprofilingenabled(false).
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list