[Webkit-unassigned] [Bug 33096] [Qt] DRT: Support evaluateInWebInspector(), setTimerProfilingEnabled() and display().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33096


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eric at webkit.org




--- Comment #3 from Eric Seidel <eric at webkit.org>  2010-01-02 12:22:02 PST ---
(In reply to comment #2)
> Attachment 45733 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:41: 
> qt_drt_setTimelineProfilingEnabled is incorrectly named. Don't use underscores
> in your identifier names.  [readability/naming] [4]
> WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:49: 
> qt_drt_webinspector_execute_script is incorrectly named. Don't use underscores
> in your identifier names.  [readability/naming] [4]
> WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp:402:  Could not find a
> newline character at the end of the file.  [whitespace/ending_newline] [5]
> Total errors found: 3

If these are false positives we should definitely file a bug about them so we
can get them fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.