[Webkit-unassigned] [Bug 35479] SVG fallback color doesn't work for bogus gradients.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 27 11:59:08 PST 2010


https://bugs.webkit.org/show_bug.cgi?id=35479





--- Comment #3 from Dirk Schulze <krit at webkit.org>  2010-02-27 11:59:08 PST ---
(In reply to comment #2)
> Attachment 49685 [details] did not pass style-queue:
> 
> Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> WebCore/svg/graphics/SVGPaintServer.cpp:129:  Tests for true/false,
> null/non-null, and zero/non-zero should all be done without equality
> comparisons.  [readability/comparison_to_zero] [5]
> Total errors found: 1 in 9 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I check if the size is zero, negative values are allowed. I had problems with
this rule multiple times now, can't we get rid of it?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list