[Webkit-unassigned] [Bug 35449] Add ability to hide WebFrame scrollbars and to allow scrollbars to overlap with content.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35449


Timothy Hatcher <timothy at hatcher.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49637|review?                     |review+
               Flag|                            |




--- Comment #2 from Timothy Hatcher <timothy at hatcher.name>  2010-02-26 14:16:40 PST ---
(From update of attachment 49637)

> +        frame.size.height = (allowScrollersToOverlapContent ? NSMaxY([[self horizontalScroller] frame]) 
> +                                                                         : NSMinY([[self horizontalScroller] frame]));

> +        frame.size.width = (allowScrollersToOverlapContent ? NSMaxX([[self verticalScroller] frame]) 
> +                                                                        : NSMinX([[self verticalScroller] frame]));

Just put those on one line. You are not saving much space.


> +    [[self window] disableFlushWindow];
> +    [super tile];
> +    [[self contentView] setFrame:[self contentViewFrame]];
> +    [[self window] enableFlushWindow];

I don't think you need disableFlushWindow here. I don't think tile will display
and flush.


> +        if (allowScrollersToOverlapContent)
> +            [self setDrawsBackground:NO];

Does this need set back to the previous value if allowScrollersToOverlapContent
becomes NO again?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.