[Webkit-unassigned] [Bug 30676] Geolocation maximumAge property is not applied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30676





--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-02-26 04:53:56 PST ---
(From update of attachment 49374)

> +void Geolocation::GeoNotifier::makeSuccessCallback(Geoposition* position)
> +{
> +    m_successCallback->handleEvent(position);
> +}

Why do you call these callbacks, when you are not really using them as
callbacks? Because they are called async or so? or because you use them as
notifiers?


> +                notifier->setFatalError(PositionError::create(PositionError::POSITION_UNAVAILABLE, "Failed to start Geolocation service"));

I think WebKit has a class to put strings that are supposed to be translated,
though I have never used that.


> +void Geolocation::makeCachedPositionCallbacks()
> +{

I got a bit confused with your make callback terminology. So appearently you
have callbacks and you add things for it to handle?

judging from 

void Geolocation::GeoNotifier::makeSuccessCallback(Geoposition* position)
{
    m_successCallback->handleEvent(position);
}

So is this some kind of "handleEventAsSuccess" ?


> +bool Geolocation::haveSuitableCachedPosition(PositionOptions* options)
> +{
> +    if (!m_positionCache->cachedPosition())
> +        return false;
> +    if (!options->hasMaximumAge())
> +        return true;
> +    if (!options->maximumAge())
> +        return false;

It is a bit confusing that hasMaximumAge is false for 0 (which I assume if this
is compliant with the spec), but you still have the 0 in the maximumAge, which
you check afterward.

>  void Geolocation::setIsAllowed(bool allowed)

setAllowed should be OK I guess.

>      m_allowGeolocation = allowed ? Yes : No;

Why Yes, No and not true false?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.