[Webkit-unassigned] [Bug 33995] Web Inspector: Additional instrumentation for Timeline

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33995


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49575|review?                     |
               Flag|                            |




--- Comment #34 from Pavel Feldman <pfeldman at chromium.org>  2010-02-26 02:48:53 PST ---
(From update of attachment 49575)
th * 2 };
> +        var newElementPosition = { x: 0, y: 0, width: preferredWidth + scrollerWidth, height: preferredHeight };
> +        newElementPosition.heightWithArrow = newElementPosition.height + arrowHeight;

Why not to assign inline?

> +            if (newElementPosition.y + newElementPosition.heightWithArrow - borderWidth >= totalHeight) {
> +                newElementPosition.height = totalHeight - anchorBox.y - anchorBox.height - borderRadius * 2 - arrowHeight;
>              }

No need for { }

> +            if (sendRequestRecord) {// False for main resource.
>                  formattedRecord.startTime = sendRequestRecord._responseReceivedFormattedTime;
> +                formattedRecord.callerScriptName = sendRequestRecord.callerScriptName;
> +                formattedRecord.callerScriptLine = sendRequestRecord.callerScriptLine;

We wanted to remove this, right?

> +            }
> +        } else if (record.type === WebInspector.TimelineAgent.RecordType.TimerInstall) {
> +            formattedRecord.timeout = record.data.timeout;
> +            formattedRecord.singleShot = record.data.singleShot;
> +            this._timerRecords[record.data.timerId] = formattedRecord;
> +        } else if (record.type === WebInspector.TimelineAgent.RecordType.TimerFire ||
> +                   record.type === WebInspector.TimelineAgent.RecordType.TimerRemove) {
> +            var timerInstalledRecord = this._timerRecords[record.data.timerId];
> +            if (timerInstalledRecord) {
> +                formattedRecord.callSiteScriptName = timerInstalledRecord.callerScriptName;
> +                formattedRecord.callSiteScriptLine = timerInstalledRecord.callerScriptLine;
> +                formattedRecord.timeout = timerInstalledRecord.timeout;
> +                formattedRecord.singleShot = timerInstalledRecord.singleShot;
> +            }

I am not a great fan of this code, would prefer link to the timer install
instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.