[Webkit-unassigned] [Bug 35325] [v8] Missing wasCreatedFromMarkup fn in V8LazyEventListener.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35325


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49355|review?                     |review-
               Flag|                            |




--- Comment #2 from Nate Chapin <japhet at chromium.org>  2010-02-25 10:37:44 PST ---
(From update of attachment 49355)
> +        Patch was tested and passed the Chromium try bots.

Try bot info shouldn't go in the ChangeLog. If you're going to include it,
leave it in the bug.

> +        // Needed to match JSC semantics inside shared SVG code.
> +        virtual bool wasCreatedFromMarkup() const { return true; }
> +

This comment doesn't really help me understand why this change is necessary. 
It would probably be better off explaining why either set of javascript
bindings needs to override EventListener::wasCreatedFromMarkup(), rather than
just saying that we're matching JSC. Alternatively, you could present a case
why a comment isn't necessary here :)


r- on nitpicks.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.