[Webkit-unassigned] [Bug 35213] [chromium] hardcoded gcc path breaks solaris build

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35213


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49488|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #17 from David Levin <levin at chromium.org>  2010-02-25 08:34:39 PST ---
(From update of attachment 49488)
I'll do these fixes and land it.


There should be spaces around the ~= as noted previously but I missed this in
the last review :(.

> Index: WebCore/dom/make_names.pl

This could be slightly simpler my moving where preprocessor is declared.

> +require Config;
> +my $gccLocation = "";
> +if (($Config::Config{'osname'})=~/solaris/i) {
> +    $gccLocation = "/usr/sfw/bin/gcc";
> +} else {
> +    $gccLocation = "/usr/bin/gcc";
> +}
> +my $preprocessor = $gcclocation . " -E -P -x c++";

Something I didn't mention before: I think the comment "Detect OS. ..." is
redundant with the code (-- It is a translation of the code into English so it
doesn't seem useful), so it should be removed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.