[Webkit-unassigned] [Bug 35340] [Qt] Enable alternate HTML/JavaScript front-ends for Web Inspector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35340


Laszlo Gombos <laszlo.1.gombos at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49418|review?                     |review-
               Flag|                            |




--- Comment #5 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2010-02-25 06:46:20 PST ---
(From update of attachment 49418)
Approach looks good to me, this is a great addition to QtWebKit.

ChangeLog does not seems to follow the template. The "Reviewed by NOBODY
(OOPS!)." part is missing. Also I have added [Qt] to the title of the bug, so
if you could regenerate the ChnageLog that would be good.

Based on IRC discussion with Kenneth, Jamey and myself we concluded the the API
for setting/getting the Inspector URL should be:

void QWebSettings::setInspectorUrl (const QUrl &inspector);
QUrl QWebSettings::inspectorUrl() const;

Please document these new APIs well.

This means that changes in InspectorClientQt.h would not be necessary but your
style fixes are very welcome.

r- to use the new proposed API; general approach is good.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.