[Webkit-unassigned] [Bug 35373] XSSAuditor is super super super slow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35373





--- Comment #3 from James Robinson <jamesr at chromium.org>  2010-02-24 18:25:05 PST ---
Here are the two really bad callstacks on the second load:

    0.0%    91.8%    WebCore                   
WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool)
    0.1%    91.7%    WebCore                    
WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&,
WebCore::HTMLTokenizer::State)
    0.0%    91.5%    WebCore                     
WebCore::HTMLTokenizer::processToken()
    0.0%    91.5%    WebCore                      
WebCore::HTMLParser::parseToken(WebCore::Token*)
    0.0%    90.3%    WebCore                       
WebCore::Element::setAttributeMap(WTF::PassRefPtr<WebCore::NamedNodeMap>,
WebCore::FragmentScriptingPermission)
    0.0%    90.2%    WebCore                        
WebCore::StyledElement::attributeChanged(WebCore::Attribute*, bool)
    0.0%    58.2%    WebCore                         
WebCore::HTMLInputElement::parseMappedAttribute(WebCore::MappedAttribute*)
    0.0%    58.1%    WebCore                          
WebCore::HTMLTextFormControlElement::parseMappedAttribute(WebCore::MappedAttribute*)
    0.0%    51.5%    WebCore                           
WebCore::createAttributeEventListener(WebCore::Node*, WebCore::Attribute*)
    0.0%    51.5%    WebCore                            
WebCore::XSSAuditor::canCreateInlineEventListener(WebCore::String const&,
WebCore::String const&) const

and

    0.0%    91.8%    WebCore                   
WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool)
    0.1%    91.7%    WebCore                    
WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&,
WebCore::HTMLTokenizer::State)
    0.0%    91.5%    WebCore                     
WebCore::HTMLTokenizer::processToken()
    0.0%    91.5%    WebCore                      
WebCore::HTMLParser::parseToken(WebCore::Token*)
    0.0%    90.3%    WebCore                       
WebCore::Element::setAttributeMap(WTF::PassRefPtr<WebCore::NamedNodeMap>,
WebCore::FragmentScriptingPermission)
    0.0%    90.2%    WebCore                        
WebCore::StyledElement::attributeChanged(WebCore::Attribute*, bool)
    0.0%    58.2%    WebCore                         
WebCore::HTMLInputElement::parseMappedAttribute(WebCore::MappedAttribute*)
    0.0%    25.5%    WebCore                         
WebCore::HTMLSelectElement::parseMappedAttribute(WebCore::MappedAttribute*)
    0.0%    25.5%    WebCore                          
WebCore::createAttributeEventListener(WebCore::Node*, WebCore::Attribute*)
    0.0%    25.4%    WebCore                           
WebCore::XSSAuditor::canCreateInlineEventListener(WebCore::String const&,
WebCore::String const&) const

They don't make sense to me - why would the XSSAuditor have to check anything
coming out of the HTMLTokenizer?  This is HTML served up by the server, not
coming from any user-controlled data.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.