[Webkit-unassigned] [Bug 35347] Convert the zoom mode into a proper enum

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35347


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |levin at chromium.org




--- Comment #7 from David Levin <levin at chromium.org>  2010-02-24 10:52:32 PST ---
(In reply to comment #6)
> Created an attachment (id=49410)
 --> (https://bugs.webkit.org/attachment.cgi?id=49410) [details]
> Convert the zoom mode into a proper enum (try 3)
> 
> Adding WebCore/page/ZoomMode.h and including that instead of the whole
> Settings.h.

A few notes/nits that you may want to fix:
1. Your copyright says 2009. It should be 2010.
2. The newly added file doesn't have header guards. (ifndef/define/endif).
3. The header file wasn't added to xcode project file
WebCore.xcodeproj/project.pbxproj

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.