[Webkit-unassigned] [Bug 35341] Expose Database object of currently active task on the database thread

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35341


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49390|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #3 from Jeremy Orlow <jorlow at chromium.org>  2010-02-24 07:32:45 PST ---
(From update of attachment 49390)
Close...but I think it's worth adding an assert.

> diff --git a/WebCore/storage/DatabaseThread.cpp b/WebCore/storage/DatabaseThread.cpp
> index ec4c6d1..e5a21d1 100644
> --- a/WebCore/storage/DatabaseThread.cpp
> +++ b/WebCore/storage/DatabaseThread.cpp
> @@ -42,6 +42,7 @@ namespace WebCore {
>  
>  DatabaseThread::DatabaseThread()
>      : m_threadID(0)
> +    , m_databaseOfCurrentTask(0)
>      , m_transactionClient(new SQLTransactionClient())
>      , m_transactionCoordinator(new SQLTransactionCoordinator())
>      , m_cleanupSync(0)
> @@ -96,7 +97,9 @@ void* DatabaseThread::databaseThread()
>  
>      AutodrainedPool pool;
>      while (OwnPtr<DatabaseTask> task = m_queue.waitForMessage()) {

ASSERT it's 0 first

> +        m_databaseOfCurrentTask = task->database();
>          task->performTask();
> +        m_databaseOfCurrentTask = 0;
>          pool.cycle();
>      }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.