[Webkit-unassigned] [Bug 35333] [GTK] video playback position query flood when mouse over the video element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35333





--- Comment #3 from Philippe Normand <pnormand at igalia.com>  2010-02-24 06:16:08 PST ---
(In reply to comment #2)
> +        if (g_str_equal(GST_MESSAGE_SRC_NAME(message), "pipeline"))
> +            mp->updateStates();
> 
> Do a pointer comparison instead
> 

you mean comparing with m_playBin? It can't be accessed from there :/ If found
this simpler than passing n_playBin into callback data or implementing an
accessor.

> Position/Duration queries can fail in the beginning but could return something
> useful later. So the approach taken here is wrong IMHO.
> 

I don't cache position ;) For duration it is indeed cached but I made sure that
if the query fails at the beginning it will be re-attempted later when playback
started.

> Why do you rename the playbin2 to "pipeline"? :)

Dunno... suggestions? :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.