[Webkit-unassigned] [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35210





--- Comment #13 from Gustavo Noronha (kov) <gns at gnome.org>  2010-02-24 05:23:20 PST ---
(In reply to comment #11)
> > So you just need to remove the relevant tests from there =).
> 
> Unfortunately, some tests still fail. I suppose (unsure) that's because our
> implementation denies by default. A few tests pass. I don't known if this is by
> only chance. I uncommented the passing tests in updated patch.

I think it's because our DumpRenderTree needs to be brought up to date with the
GeoLocation stuff. If you look at these files, and search for Geo, you'll see
what needs to be done:

WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
WebKitTools/DumpRenderTree/LayoutTestController.cpp

I think we should try to get those implemented for this patch, so we can test
the permission giving, and denying.

One more comment about the API. I agree to have the 'cancelled' signal, but can
we name it geolocation-policy-decision-cancelled, so it's consistent with the
other signal?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.